----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66294/#review200327 -----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSync.java Line 112 (original), 112 (patched) <https://reviews.apache.org/r/66294/#comment281027> This creates a PMD violation. Could you please check? ``` <?xml version="1.0" encoding="UTF-8"?> <pmd version="5.5.1" timestamp="2018-04-02T19:00:28.218"> <file name="/Users/vperiasamy/git/tlp-ranger/master/ranger/ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSync.java"> <violation beginline="107" endline="107" begincolumn="44" endcolumn="52" rule="UnusedFormalParameter" ruleset="Unused Code" package="org.apache.ranger.usergroupsync" class="UserGroupSync" method="syncUserGroup" variable="forceSync" externalInfoUrl="https://pmd.github.io/pmd-5.5.1/pmd-java/rules/java/unusedcode.html#UnusedFormalParameter"; priority="3"> Avoid unused method parameters such as 'forceSync'. </violation> </file> </pmd> ``` - Velmurugan Periasamy On April 2, 2018, 10:39 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66294/ > ----------------------------------------------------------- > > (Updated April 2, 2018, 10:39 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1985 > https://issues.apache.org/jira/browse/RANGER-1985 > > > Repository: ranger > > > Description > ------- > > – Add other meta-data to sync source popup (like group search first enabled) > – Distinguish between full sync and incremental sync events > – Show synctime, last modified time in event time format > – In addition to #users/groups sync'ed from source, show added/updated users > (explore this to see how best to show this without confusing users) > > > Diffs > ----- > > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 65fc51cc > > security-admin/db/mysql/patches/031-create-schema-for-usersync-audit-info.sql > 2405a3ef > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 0634776f > > security-admin/db/oracle/patches/031-create-schema-for-usersync-audit-info.sql > e03e8937 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 70f4bcc7 > > security-admin/db/postgres/patches/031-create-schema-for-usersync-audit-info.sql > 2227f011 > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > d59788cc > > security-admin/db/sqlanywhere/patches/031-create-schema-for-usersync-audit-info.sql > 26d857b5 > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > f67f1094 > > security-admin/db/sqlserver/patches/031-create-schema-for-usersync-audit-info.sql > 362f4152 > > security-admin/src/main/java/org/apache/ranger/entity/XXUgsyncAuditInfo.java > 56098338 > > security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java > 85a96512 > > security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoServiceBase.java > bf6f6e15 > > security-admin/src/main/java/org/apache/ranger/view/VXFileSyncSourceInfo.java > d8c66ca1 > > security-admin/src/main/java/org/apache/ranger/view/VXLdapSyncSourceInfo.java > fd2d8e11 > security-admin/src/main/java/org/apache/ranger/view/VXUgsyncAuditInfo.java > 6fef928a > > security-admin/src/main/java/org/apache/ranger/view/VXUnixSyncSourceInfo.java > 47bd839d > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java > 7d85f33b > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > 54a519a9 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > 85cba3c5 > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 45eeb1bc > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/FileSyncSourceInfo.java > 02387e11 > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/LdapSyncSourceInfo.java > 318138d4 > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/UgsyncAuditInfo.java > 9dfd3a55 > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/UnixSyncSourceInfo.java > 97b95a1f > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java > a50b0c76 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > 9d3112dd > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java > c58589ef > ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSync.java > f078cb8d > > ugsync/src/test/java/org/apache/ranger/usergroupsync/PolicyMgrUserGroupBuilderTest.java > 312ea9b8 > > > Diff: https://reviews.apache.org/r/66294/diff/2/ > > > Testing > ------- > > 1. Performed functional tests with unix, file, and LDAP/AD as sync sources > 2. Performed functional tests with different combinations of group search and > user search with AD/LDAP as sync source > 3. Also ran some functional tests with and without incremental sync and > nested groups > > > Thanks, > > Sailaja Polavarapu > >
