----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61116/#review200647 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java Line 63 (original), 63 (patched) <https://reviews.apache.org/r/61116/#comment281439> Can you please revise the patch? Fails to apply. ``` $ git apply --check -v < ~/Downloads/RANGER-1664.1.patch Checking patch agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java... error: while searching for: public static final String EMBEDDED_SERVICEDEF_NIFI_NAME = "nifi"; public static final String EMBEDDED_SERVICEDEF_ATLAS_NAME = "atlas"; public static final String EMBEDDED_SERVICEDEF_WASB_NAME = "wasb"; public static final String PROPERTY_CREATE_EMBEDDED_SERVICE_DEFS = "ranger.service.store.create.embedded.service-defs"; error: patch failed: agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java:63 error: agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java: patch does not apply Checking patch agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json... ``` - Velmurugan Periasamy On Nov. 20, 2017, 1:11 p.m., Anandsagar Kothapalli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61116/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2017, 1:11 p.m.) > > > Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-1664 > https://issues.apache.org/jira/browse/RANGER-1664 > > > Repository: ranger > > > Description > ------- > > Add-ons to support Azure Data lake(ADLS) in Ranger Authorization Model > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 0bc09f60 > agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61116/diff/1/ > > > Testing > ------- > > Tested creating a VM > > > Thanks, > > Anandsagar Kothapalli > >
