-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/#review201002
-----------------------------------------------------------




ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 97 (patched)
<https://reviews.apache.org/r/66584/#comment281935>

    variable name "sessionId" can be renamed to  sessionIdCookie



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 814 (patched)
<https://reviews.apache.org/r/66584/#comment281936>

    The logic in method tryUploadUserGroupAuditInfoWithCookie, 
tryUploadMUserWithCookie & tryUploadUserGroupInfoWithCookie is similiar and can 
be brought in one common method with json string and url as argument which can 
be reused in other method.
    
    eg tryUploadEntityInfoWithCookie(JSON, URL);


- Nixon Rodrigues


On April 12, 2018, 12:50 p.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66584/
> -----------------------------------------------------------
> 
> (Updated April 12, 2018, 12:50 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2021 and RANGER-2064
>     https://issues.apache.org/jira/browse/RANGER-2021
>     https://issues.apache.org/jira/browse/RANGER-2064
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger Usersync should use cookie based authentication for subsequent 
> requests to Ranger admin.
> 
> 
> Diffs
> -----
> 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
>  e9e356a 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  b30b051 
>   unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 
> 
> 
> Diff: https://reviews.apache.org/r/66584/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Validated rangerusersync is not flooding table.
> 2)Validated if cookie is used by usersync client for subsequent requests to 
> ranger-admin.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Reply via email to