-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66852/#review202122
-----------------------------------------------------------


Fix it, then Ship it!





ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
Line 854 (original), 854 (patched)
<https://reviews.apache.org/r/66852/#comment283754>

    Use a configurable param for this?


- Velmurugan Periasamy


On April 27, 2018, 5:48 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66852/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 5:48 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1852
>     https://issues.apache.org/jira/browse/RANGER-1852
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Incrementing timestamp value for groups to 1sec instead of 1min. This is 
> in-sync with timestamp value for users.
> 
> 
> Diffs
> -----
> 
>   
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
>  2288ab8e 
> 
> 
> Diff: https://reviews.apache.org/r/66852/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Verified the existing unit tests are ran successfully.
> 2. Verified basic usersync functionality with openldap server.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Reply via email to