----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66950/#review202787 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On May 9, 2018, 3:51 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66950/ > ----------------------------------------------------------- > > (Updated May 9, 2018, 3:51 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2096 > https://issues.apache.org/jira/browse/RANGER-2096 > > > Repository: ranger > > > Description > ------- > > There is unnecessary dead code in AbstractBaseResourceService.java, which > stores the child services in a service map, which is only called from > RangerBizUtil.getVObject/getMObject methods, which are only called from test > method. > > This can be removed safely. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 00bda59af > > security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java > a64bb3048 > security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java > 174f919a3 > > > Diff: https://reviews.apache.org/r/66950/diff/2/ > > > Testing > ------- > > Tested locally, and on a cluster > > > Thanks, > > Zsombor Gegesy > >
