> On June 1, 2018, 4:37 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json > > Lines 33 (patched) > > <https://reviews.apache.org/r/67409/diff/1/?file=2034264#file2034264line33> > > > > mandatory attribute is no more required. There are many resource > > definition attributes (validationRegEx, validationMesage, uiHint, > > mandatory, and perhaps lookupSupported (default:false), > > recursiveSupported(default:false), excludesSupported(default:false)) that > > need not be specified as their default values are good enough. Service > > definition can be concise if these attributes are not explicitly specified. > > Also, perhaps excludesSupported's default value could be changed to > > 'true' in RangerServiceDef.RangerResourceDef class.
RangerServiceDef.RangerResourceDef changes to default values at model level we can review all entities and address it in a new JIRA. For this change I have taken care of validationRegEx, validationMesage, uiHint, mandatory, lookupSupported and recursiveSupported values in the service def - Ramesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67409/#review204190 ----------------------------------------------------------- On June 4, 2018, 9:51 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67409/ > ----------------------------------------------------------- > > (Updated June 4, 2018, 9:51 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-2117 > https://issues.apache.org/jira/browse/RANGER-2117 > > > Repository: ranger > > > Description > ------- > > RANGER-2117:RangerKafkaAuthorizer to support new resources and operations > which are in Apache Kafka 1.0.0 > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json > 839d780 > > plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java > 630d1af > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java > 23b9299 > plugin-kafka/src/test/resources/kafka-policies.json d0e469a > > security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10015.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67409/diff/2/ > > > Testing > ------- > > Tested in Local VM > > > Thanks, > > Ramesh Mani > >
