> On June 12, 2018, 4:19 a.m., Mehul Parikh wrote: > > @david : Your patch is still not getting applied, it is a diff file, if you > > can just make a patch file and attach it on review board. it will be > > helpful : > > > > As mentioned in Wiki page : > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244 > > > > $ git add <modified|add|deleted-files> > > $ git commit -m "RANGER-<JIRANUMBER>: <description of the JIRA fix>" > > $ git format-patch -n HEAD~ > > daniel voros wrote: > @Mehul, sorry about that! I've reuploaded the patch, generated with > format-patch. I was able to apply it with `git am`. > > p.s. my mom's calling me David sometimes, but I always thought it's > because my older brother David. How did you know?! (:
:) - Apologies Daniel, mentioned David by mistake. - Mehul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67475/#review204582 ----------------------------------------------------------- On June 6, 2018, 1:10 p.m., daniel voros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67475/ > ----------------------------------------------------------- > > (Updated June 6, 2018, 1:10 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2123 > https://issues.apache.org/jira/browse/RANGER-2123 > > > Repository: ranger > > > Description > ------- > > Leaving the pass empty will result in a JS error, while a wrong password will > get the server response: > ``` > The username or password you entered is incorrect.. > ``` > vs > ``` > The username or password you entered is incorrect... > ``` > Lets go with a single '.' in both cases! > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java > 35d75438f > security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc > > > Diff: https://reviews.apache.org/r/67475/diff/3/ > > > Testing > ------- > > > Thanks, > > daniel voros > >
