----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67545/#review204694 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On June 12, 2018, 2:04 p.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67545/ > ----------------------------------------------------------- > > (Updated June 12, 2018, 2:04 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2133 > https://issues.apache.org/jira/browse/RANGER-2133 > > > Repository: ranger > > > Description > ------- > > Good coding practices for REST classes and unit tests > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java c206acb > security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java > 529fd5b > > security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java > f4ea957 > > > Diff: https://reviews.apache.org/r/67545/diff/1/ > > > Testing > ------- > > tested on local machine. > > > Thanks, > > Nikhil P > >
