[
https://issues.apache.org/jira/browse/RANGER-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534019#comment-16534019
]
Velmurugan Periasamy edited comment on RANGER-1951 at 7/5/18 6:58 PM:
----------------------------------------------------------------------
This patch creates issue during preparation of source release for 1.1.0. So I
am reopening this issue and reverting this commit in ranger-1.1 and ranger-1
branches. Leaving the commit in master branch and setting fix version as 2.0.0.
[~zsombor] - Can you please take a look?
+Steps to reproduce:+ (as seen here
[http://ranger.apache.org/quick_start_guide.html)|http://ranger.apache.org/quick_start_guide.html)+]
1] Git clone and build the project
2] Create the source artifacts for release
3] Now as part of verification, try building from the source tar.gz file. It
fails with the below error.
{{[INFO]
------------------------------------------------------------------------}}
{{[INFO] Building Ranger Util 1.1.0}}
{{[INFO]
------------------------------------------------------------------------}}
{{[INFO]}}
{{[INFO] — maven-clean-plugin:2.6.1:clean (default-clean) @ ranger-util ---}}
{{[INFO] Deleting
/Users/user123/apache-release/1.1.0/verification/ver2/apache-ranger-1.1.0/ranger-util/target}}
{{[INFO]}}
{{[INFO] — maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
ranger-util ---}}
{{[INFO]}}
{{[INFO] — maven-enforcer-plugin:1.4.1:enforce (enforce-versions) @
ranger-util ---}}
{{[INFO]}}
{{[INFO] — maven-antrun-plugin:1.7:run (generate-version-annotation) @
ranger-util ---}}
{{[INFO] Executing tasks}}{{main:}}
{{ [exec] fatal: Not a git repository (or any of the parent directories):
.git}}
{{ [exec] Traceback (most recent call last):}}
{{ [exec] File
"/Users/user123/apache-release/1.1.0/verification/ver2/apache-ranger-1.1.0/ranger-util/src/scripts/saveVersion.py",
line 150, in <module>}}
{{ [exec] main()}}
{{ [exec] File
"/Users/user123/apache-release/1.1.0/verification/ver2/apache-ranger-1.1.0/ranger-util/src/scripts/saveVersion.py",
line 68, in main}}
{{ [exec] output = check_output(query)}}
{{ [exec] File
"/Users/user123/apache-release/1.1.0/verification/ver2/apache-ranger-1.1.0/ranger-util/src/scripts/saveVersion.py",
line 40, in check_output}}
{{ [exec] output = subprocess.check_output(query)}}
{{ [exec] File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output}}
{{ [exec] raise CalledProcessError(retcode, cmd, output=output)}}
{{ [exec] subprocess.CalledProcessError: Command '['git', 'rev-parse',
'HEAD']' returned non-zero exit status 128}}
{{[INFO]}}
{{[INFO]
------------------------------------------------------------------------}}
{{[INFO] Skipping ranger}}
{{[INFO] This project has been banned from the build due to previous
failures.}}
{{[INFO]
------------------------------------------------------------------------}}{{}}
was (Author: vperiasamy):
This patch creates issue during preparation of source release for 1.1.0. So I
am reopening this issue and reverting this commit in ranger-1.1 and ranger-1
branches. Leaving the commit in master branch and setting fix version as 2.0.0.
[~zsombor] - Can you please take a look?
+Steps to reproduce: (as seen here
http://ranger.apache.org/quick_start_guide.html)+
1] Git clone and build the project
2] Create the source artifacts for release
3] Now as part of verification, try building from the source tar.gz file. It
fails with the below error.
{{[INFO]
------------------------------------------------------------------------}}
{{[INFO] Building Ranger Util 1.1.0}}
{{[INFO]
------------------------------------------------------------------------}}
{{[INFO]}}
{{[INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ ranger-util ---}}
{{[INFO] Deleting
/Users/user123/apache-release/1.1.0/verification/ver2/apache-ranger-1.1.0/ranger-util/target}}
{{[INFO]}}
{{[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
ranger-util ---}}
{{[INFO]}}
{{[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-versions) @
ranger-util ---}}
{{[INFO]}}
{{[INFO] --- maven-antrun-plugin:1.7:run (generate-version-annotation) @
ranger-util ---}}
{{[INFO] Executing tasks}}{{main:}}
{{ [exec] fatal: Not a git repository (or any of the parent directories): .git}}
{{ [exec] Traceback (most recent call last):}}
{{ [exec] File
"/Users/user123/apache-release/1.1.0/verification/ver2/apache-ranger-1.1.0/ranger-util/src/scripts/saveVersion.py",
line 150, in <module>}}
{{ [exec] main()}}
{{ [exec] File
"/Users/user123/apache-release/1.1.0/verification/ver2/apache-ranger-1.1.0/ranger-util/src/scripts/saveVersion.py",
line 68, in main}}
{{ [exec] output = check_output(query)}}
{{ [exec] File
"/Users/user123/apache-release/1.1.0/verification/ver2/apache-ranger-1.1.0/ranger-util/src/scripts/saveVersion.py",
line 40, in check_output}}
{{ [exec] output = subprocess.check_output(query)}}
{{ [exec] File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 573, in check_output}}
{{ [exec] raise CalledProcessError(retcode, cmd, output=output)}}
{{ [exec] subprocess.CalledProcessError: Command '['git', 'rev-parse', 'HEAD']'
returned non-zero exit status 128}}
{{[INFO]}}
{{[INFO]
------------------------------------------------------------------------}}
{{[INFO] Skipping ranger}}
{{[INFO] This project has been banned from the build due to previous failures.}}
{{[INFO]
------------------------------------------------------------------------}}{{}}
> build problems with the saveVersion.py script
> ---------------------------------------------
>
> Key: RANGER-1951
> URL: https://issues.apache.org/jira/browse/RANGER-1951
> Project: Ranger
> Issue Type: Bug
> Components: build-infra
> Affects Versions: 0.7.1
> Reporter: Zsombor Gegesy
> Assignee: Zsombor Gegesy
> Priority: Major
> Fix For: 2.0.0
>
> Attachments: RANGER-1951-1.patch
>
>
> Currently the saveVersion.py has the following problems:
> * it doesn't work with python3 due to 'inconsistent whitespace usage' and
> because in python3 the byte array is different from a string
> * The checksum is generated from all the java source files from
> ranger-util/target, which contains at most one java file - a previously
> generated ranger-util/target/gen/org/apache/ranger/common/package-info.java
> *
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
