----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67835/#review205842 -----------------------------------------------------------
Ship it! Ship It! - Zsombor Gegesy On júl. 7, 2018, 5:45 de, Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67835/ > ----------------------------------------------------------- > > (Updated júl. 7, 2018, 5:45 de) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2150 > https://issues.apache.org/jira/browse/RANGER-2150 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Unit test coverage for XUserMgr and UserMgr class need > to be increased. > > Currently Unit Test coverage of XUserMgr is 33.5% and UserMgr class is 54.9% > Total No. of test cases in TestXUserMgr class are: 37 > Total No. of test cases in TestUserMgr class are: 23 > > **Proposed Solution:** > Proposed patch contains lot of additional unit test cases and modification in > existing unit test cases. > Statistics after the patch are: > Test coverage of XUserMgr is 90.2% and UserMgr class is 85.3% > Total No. of test cases in TestXUserMgr class are: 100 > Total No. of test cases in TestUserMgr class are: 41 > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6d94e4f > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 7f5eab7 > security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 10453a5 > security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java > 39c60a9 > > > Diff: https://reviews.apache.org/r/67835/diff/2/ > > > Testing > ------- > > Tested on my local environment by using command : > > mvn clean compile package assembly:assembly install > > [INFO] Reactor Summary: > [INFO] > [INFO] ranger ............................................. SUCCESS [ 9.399 > s] > [INFO] Jdbc SQL Connector ................................. SUCCESS [ 2.039 > s] > [INFO] Credential Support ................................. SUCCESS [ 0.792 > s] > [INFO] Audit Component .................................... SUCCESS [ 2.001 > s] > [INFO] Common library for Plugins ......................... SUCCESS [ 3.299 > s] > [INFO] Installer Support Component ........................ SUCCESS [ 0.398 > s] > [INFO] Credential Builder ................................. SUCCESS [ 1.066 > s] > [INFO] Embedded Web Server Invoker ........................ SUCCESS [ 1.243 > s] > [INFO] Key Management Service ............................. SUCCESS [ 2.776 > s] > [INFO] ranger-plugin-classloader .......................... SUCCESS [ 0.463 > s] > [INFO] HBase Security Plugin Shim ......................... SUCCESS [ 2.522 > s] > [INFO] HBase Security Plugin .............................. SUCCESS [ 1.758 > s] > [INFO] Hdfs Security Plugin ............................... SUCCESS [ 1.822 > s] > [INFO] Hive Security Plugin ............................... SUCCESS [ 7.668 > s] > [INFO] Knox Security Plugin Shim .......................... SUCCESS [ 1.452 > s] > [INFO] Knox Security Plugin ............................... SUCCESS [ 4.083 > s] > [INFO] Storm Security Plugin .............................. SUCCESS [ 1.046 > s] > [INFO] YARN Security Plugin ............................... SUCCESS [ 0.924 > s] > [INFO] Ranger Util ........................................ SUCCESS [ 7.301 > s] > [INFO] Unix Authentication Client ......................... SUCCESS [ 1.258 > s] > [INFO] Security Admin Web Application ..................... SUCCESS [01:31 > min] > [INFO] KAFKA Security Plugin .............................. SUCCESS [ 4.827 > s] > [INFO] SOLR Security Plugin ............................... SUCCESS [ 5.235 > s] > [INFO] NiFi Security Plugin ............................... SUCCESS [ 0.950 > s] > [INFO] Unix User Group Synchronizer ....................... SUCCESS [03:34 > min] > [INFO] Ldap Config Check Tool ............................. SUCCESS [ 2.540 > s] > [INFO] Unix Authentication Service ........................ SUCCESS [ 4.010 > s] > [INFO] KMS Security Plugin ................................ SUCCESS [ 5.922 > s] > [INFO] Tag Synchronizer ................................... SUCCESS [ 12.373 > s] > [INFO] Hdfs Security Plugin Shim .......................... SUCCESS [ 12.243 > s] > [INFO] Hive Security Plugin Shim .......................... SUCCESS [01:00 > min] > [INFO] YARN Security Plugin Shim .......................... SUCCESS [ 6.474 > s] > [INFO] Storm Security Plugin shim ......................... SUCCESS [ 3.564 > s] > [INFO] KAFKA Security Plugin Shim ......................... SUCCESS [ 1.029 > s] > [INFO] SOLR Security Plugin Shim .......................... SUCCESS [ 6.671 > s] > [INFO] Atlas Security Plugin Shim ......................... SUCCESS [ 2.348 > s] > [INFO] KMS Security Plugin Shim ........................... SUCCESS [ 2.024 > s] > [INFO] ranger-examples .................................... SUCCESS [ 0.422 > s] > [INFO] Ranger Examples - Conditions and ContextEnrichers .. SUCCESS [ 1.269 > s] > [INFO] Ranger Examples - SampleApp ........................ SUCCESS [ 0.380 > s] > [INFO] Ranger Examples - Ranger Plugin for SampleApp ...... SUCCESS [ 0.942 > s] > [INFO] Ranger Tools ....................................... SUCCESS [ 1.384 > s] > [INFO] Atlas Security Plugin .............................. SUCCESS [ 1.660 > s] > [INFO] Sqoop Security Plugin .............................. SUCCESS [ 1.611 > s] > [INFO] Sqoop Security Plugin Shim ......................... SUCCESS [ 0.777 > s] > [INFO] Kylin Security Plugin .............................. SUCCESS [ 2.375 > s] > [INFO] Kylin Security Plugin Shim ......................... SUCCESS [ 1.695 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 42:52 min > [INFO] Finished at: 2018-07-06T02:12:31+05:30 > [INFO] Final Memory: 415M/886M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Pradeep Agrawal > >
