----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68037/#review206443 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On July 25, 2018, 10:06 a.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68037/ > ----------------------------------------------------------- > > (Updated July 25, 2018, 10:06 a.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan > Periasamy. > > > Bugs: RANGER-2161 > https://issues.apache.org/jira/browse/RANGER-2161 > > > Repository: ranger > > > Description > ------- > > sometimes it is bit confusing for people they may add another another policy > item in exclude part instead of adding another one in the same allow policy > items so as part of improvement it is better to mark exclude from deny and > allow condition with some background color. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/XAOverrides.js 3832916 > security-admin/src/main/webapp/styles/xa.css b895331 > > security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html > 9596c6f > > > Diff: https://reviews.apache.org/r/68037/diff/1/ > > > Testing > ------- > > Able to differentiate allow/deny and allowExclude/DenyExclude policy item's. > > > Thanks, > > Nitin Galave > >
