----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68010/#review206733 -----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js Lines 300 (patched) <https://reviews.apache.org/r/68010/#comment289827> Why are we reloading the page here? any specific reason if reloading page is for getting the newly updated collection for policies then we should manually get updated collection(policies) by using backbone's collection.fetch method. We should avoid such action(reload) in single page application (SPA) - Nitin Galave On July 27, 2018, 6:45 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68010/ > ----------------------------------------------------------- > > (Updated July 27, 2018, 6:45 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, > Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy. > > > Bugs: RANGER-2153 > https://issues.apache.org/jira/browse/RANGER-2153 > > > Repository: ranger > > > Description > ------- > > Supply the function of reverting policy history version. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js > a0b46fdf6 > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js > 206bb96ac > > > Diff: https://reviews.apache.org/r/68010/diff/2/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
