----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68177/#review207213 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java Line 348 (original), 351 (patched) <https://reviews.apache.org/r/68177/#comment290507> Would this cause token replacement to not work when optWildcar is false? Please review. - Madhan Neethiraj On Aug. 14, 2018, 1:26 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68177/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2018, 1:26 a.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2188 > https://issues.apache.org/jira/browse/RANGER-2188 > > > Repository: ranger > > > Description > ------- > > Time for building a Trie index for resources may become a bottleneck when > dealing with large number of resources. It is desirable to build different, > non-overlapping parts of Trie structure using multiple threads to reduce > overall build time if configured to do so. > > Also, instead of building out all Trie nodes completely (that is, by > propagating wildcard evaluators all the way to all leaves of Trie tree) at > the initialization time, it is optimal to do so as a Trie-Node is accessed > for the first time during resource lookup. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > b12d8ff11 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java > b76820cd2 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 088b729fb > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > 10c6faa92 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 1d9b865b0 > > > Diff: https://reviews.apache.org/r/68177/diff/4/ > > > Testing > ------- > > Passes all unit tests > > > Thanks, > > Abhay Kulkarni > >
