> On Aug. 14, 2018, 8:31 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java > > Line 124 (original), 130 (patched) > > <https://reviews.apache.org/r/68286/diff/1/?file=2070900#file2070900line130> > > > > Instead of creating multiple Runnable objects, one for each > > serviceVersionInfo, consider handling all updates within a single Runnable.
All post-commit/post-completion tasks are run in a single transaction. Therefore, overhead of running multiple Runnable tasks is not significantly higher than running one consolidated task. However, the complexity of consolidation code (in all conditions) does not justify potential savings of having one consolidated task. - Abhay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68286/#review207252 ----------------------------------------------------------- On Aug. 10, 2018, 12:58 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68286/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2018, 12:58 a.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2186 > https://issues.apache.org/jira/browse/RANGER-2186 > > > Repository: ranger > > > Description > ------- > > Policy updates to different policies within a service, when successful, > update the service's policy version. If the update transactions are > concurrent, and executed on different ranger-admin servers (in HA > configuration), then it is possible that policy-version of the transaction > that commits later overwrites policy-version of earlier transaction, > effectively losing track of the first change. > > If policy-version is updated after update to policy is committed, then the > window of such loss is greatly reduced. > > Similar considerations apply for tag updates. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java > 69ded6dc8 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 0773616f9 > > security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java > 2a62fb408 > > security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java > e1003297a > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > cb496ea8b > > > Diff: https://reviews.apache.org/r/68286/diff/1/ > > > Testing > ------- > > Passed all unit tests > > > Thanks, > > Abhay Kulkarni > >
