----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68572/#review208146 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java Lines 248 (patched) <https://reviews.apache.org/r/68572/#comment291927> String.valueOf is redundant. It already done in processIsAuditEnabledClassFieldNameForTrxLog() or check if we need to have method. processIsAuditEnabledClassFieldNameForTrxLog(). Please check in all occurance - Ramesh Mani On Aug. 30, 2018, 6:49 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68572/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2018, 6:49 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2204 > https://issues.apache.org/jira/browse/RANGER-2204 > > > Repository: ranger > > > Description > ------- > > Fixed issue where audit log values for policy service are not processed > properly while getting the transaction logs. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > ad3984d28 > > > Diff: https://reviews.apache.org/r/68572/diff/1/ > > > Testing > ------- > > 1. Verfied the existing unit tests are working fine > 2. Also verified the changes patched on a cluster and see the audits are > written properly > > > Thanks, > > Sailaja Polavarapu > >
