> On 十月 2, 2018, 4:41 p.m., Velmurugan Periasamy wrote: > > pom.xml > > Line 191 (original), 191 (patched) > > <https://reviews.apache.org/r/68864/diff/1/?file=2092451#file2092451line191> > > > > This patch does not apply. Could you please rebase? > > > > ``` > > $ git apply --check -v < > > ~/Downloads/0001-RANGER-2237-Upgrade-Kylin-version-to-2.5.0.patch > > Checking patch pom.xml... > > error: while searching for: > > <kafka.version>2.0.0</kafka.version> > > <kerby.version>1.0.0</kerby.version> > > <knox.gateway.version>1.0.0</knox.gateway.version> > > <kylin.version>2.3.0</kylin.version> > > <libpam4j.version>1.10</libpam4j.version> > > <local.lib.dir>${project.basedir}/../lib/local</local.lib.dir> > > <log4j.version>1.2.17</log4j.version> > > > > error: patch failed: pom.xml:188 > > error: pom.xml: patch does not apply > > ```
Ok,I have updated the patch please review again.Thanks. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68864/#review209154 ----------------------------------------------------------- On 十月 8, 2018, 1:51 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68864/ > ----------------------------------------------------------- > > (Updated 十月 8, 2018, 1:51 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Nitin Galave, > pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, > Venkat Ranganathan, and Velmurugan Periasamy. > > > Bugs: RANGER-2237 > https://issues.apache.org/jira/browse/RANGER-2237 > > > Repository: ranger > > > Description > ------- > > Upgrade Kylin version to 2.5.0 > > > Diffs > ----- > > pom.xml 1fd660c1a > > > Diff: https://reviews.apache.org/r/68864/diff/2/ > > > Testing > ------- > > 1. Passed all unit tests. > 2. Tested authorization works correctly with Kylin v2.5.0 > > > Thanks, > > Qiang Zhang > >
