[ 
https://issues.apache.org/jira/browse/RANGER-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649771#comment-16649771
 ] 

xiaoli commented on RANGER-2158:
--------------------------------

hi Abhay Kulkarni,we have the problem In our production environment,Our ranger 
version is 0.7.0,in some ‘updatepolicy’ case,causes the updatePolicy method to 
return execution results slowly,sometimes ,it has been five minutes when REST 
API call to update policies ,the link to 
https://issues.apache.org/jira/browse/RANGER-2236.Whether the ranger-2158 patch 
can solve the problem? 

At the same time,we ues greys tools to attrach the updatepolicy Method:

 
{{`---+Tracing }}{{for}} {{: thread_name=}}{{"http-bio-6080-exec-8"}} 
{{thread_id=0x34;is_daemon=}}{{true}}{{;priority=5;}}
{{    
}}{{`---+[33015,33015ms]org.apache.ranger.biz.ServiceDBStore:updatePolicy()}}
{{        }}{{+---[0,0ms]org.apache.commons.logging.Log:isDebugEnabled(@1862)}}
{{        
}}{{+---[1,0ms]org.apache.ranger.db.RangerDaoManager:getXXPolicy(@1866)}}
{{        
}}{{+---[1,0ms]org.apache.ranger.plugin.model.RangerPolicy:getId(@1866)}}
{{        }}{{+---[1,0ms]org.apache.ranger.db.XXPolicyDao:getById(@1866)}}
{{        
}}{{+---[1842,1841ms]org.apache.ranger.service.RangerPolicyService:getPopulatedViewObject(@1867)}}
{{        
}}{{+---[1842,0ms]org.apache.ranger.plugin.model.RangerPolicy:getService(@1873)}}
{{        
}}{{+---[2406,564ms]org.apache.ranger.biz.ServiceDBStore:getServiceByName(@1873)}}
{{        
}}{{+---[2406,0ms]org.apache.ranger.db.RangerDaoManager:getXXServiceDef(@1879)}}
{{        
}}{{+---[2406,0ms]org.apache.ranger.plugin.model.RangerService:getType(@1879)}}
{{        
}}{{+---[2609,203ms]org.apache.ranger.db.XXServiceDefDao:findByName(@1879)}}
{{        
}}{{+---[2609,0ms]org.apache.ranger.plugin.model.RangerPolicy:getService(@1885)}}
{{        
}}{{+---[2609,0ms]org.apache.ranger.plugin.model.RangerPolicy:getService(@1885)}}
{{        
}}{{+---[2609,0ms]org.apache.commons.lang.StringUtils:equalsIgnoreCase(@1885)}}
{{        
}}{{+---[2609,0ms]org.apache.ranger.plugin.model.RangerPolicy:getName(@1888)}}
{{        
}}{{+---[2609,0ms]org.apache.ranger.plugin.model.RangerPolicy:getName(@1888)}}
{{        
}}{{+---[2610,1ms]org.apache.commons.lang.StringUtils:equalsIgnoreCase(@1888)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:getResources(@1897)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:getPolicyItems(@1898)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:getDenyPolicyItems(@1899)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:getAllowExceptions(@1900)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:getDenyExceptions(@1901)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:getDataMaskPolicyItems(@1902)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:getRowFilterPolicyItems(@1903)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.entity.XXPolicy:getCreateTime(@1905)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:setCreateTime(@1905)}}
{{        }}{{+---[2610,0ms]org.apache.ranger.entity.XXPolicy:getGuid(@1906)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:setGuid(@1906)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.entity.XXPolicy:getVersion(@1907)}}
{{        
}}{{+---[2610,0ms]org.apache.ranger.plugin.model.RangerPolicy:setVersion(@1907)}}
{{        
}}{{+---[22015,19405ms]org.apache.ranger.service.RangerPolicyService:getTransactionLog(@1909)}}
{{        
}}{{+---[22015,0ms]org.apache.ranger.biz.ServiceDBStore:updatePolicySignature(@1911)}}
{{        
}}{{+---[22015,0ms]org.apache.ranger.plugin.model.RangerService:getType(@1914)}}
{{        }}{{+---[22015,0ms]java.lang.String:equals(@1914)}}
{{        
}}{{+---[24068,2053ms]org.apache.ranger.service.RangerPolicyService:update(@1918)}}
{{        
}}{{+---[24068,0ms]org.apache.ranger.db.RangerDaoManager:getXXPolicy(@1919)}}
{{        
}}{{+---[24068,0ms]org.apache.ranger.plugin.model.RangerPolicy:getId(@1919)}}
{{        }}{{+---[24068,0ms]org.apache.ranger.db.XXPolicyDao:getById(@1919)}}
{{        
}}{{+---[25172,1104ms]org.apache.ranger.biz.ServiceDBStore:deleteExistingPolicyResources(@1921)}}
{{        
}}{{+---[27394,2222ms]org.apache.ranger.biz.ServiceDBStore:deleteExistingPolicyItems(@1922)}}
{{        
}}{{+---[28248,854ms]org.apache.ranger.biz.ServiceDBStore:createNewResourcesForPolicy(@1924)}}
{{        
}}{{+---[30021,1773ms]org.apache.ranger.biz.ServiceDBStore:createNewPolicyItemsForPolicy(@1925)}}
{{        
}}{{+---[30021,0ms]org.apache.ranger.biz.ServiceDBStore:createNewPolicyItemsForPolicy(@1926)}}
{{        
}}{{+---[30021,0ms]org.apache.ranger.biz.ServiceDBStore:createNewPolicyItemsForPolicy(@1927)}}
{{        
}}{{+---[30021,0ms]org.apache.ranger.biz.ServiceDBStore:createNewPolicyItemsForPolicy(@1928)}}
{{        
}}{{+---[30021,0ms]org.apache.ranger.biz.ServiceDBStore:createNewDataMaskPolicyItemsForPolicy(@1929)}}
{{        
}}{{+---[30021,0ms]org.apache.ranger.biz.ServiceDBStore:createNewRowFilterPolicyItemsForPolicy(@1930)}}
{{        
}}{{+---[30398,377ms]org.apache.ranger.biz.ServiceDBStore:handlePolicyUpdate(@1932)}}
{{        
}}{{+---[31994,1596ms]org.apache.ranger.service.RangerPolicyService:getPopulatedViewObject(@1933)}}
{{        
}}{{+---[32606,612ms]org.apache.ranger.service.RangerDataHistService:createObjectDataHistory(@1934)}}
{{        
`—[33015,409ms]org.apache.ranger.biz.RangerBizUtil:createTrxLog(@1936)}}
This method was found to be slow to execute;

> Performance improvement to REST API call to update policies
> -----------------------------------------------------------
>
>                 Key: RANGER-2158
>                 URL: https://issues.apache.org/jira/browse/RANGER-2158
>             Project: Ranger
>          Issue Type: Bug
>          Components: Ranger
>    Affects Versions: master
>            Reporter: Ramesh Mani
>            Assignee: Abhay Kulkarni
>            Priority: Critical
>             Fix For: 2.0.0, 1.2.0
>
>
> Performance improvement to REST API call to update policies. Currently,
> 1) the update is a bit slower because of the repeated calls to DB for policy 
> objects.
> 2) policy cache need not be built while updating the policy via REST API as 
> this call if it happened to be in the timeframe of the policy download,  it 
> is slowing down the update process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to