> On 十月 26, 2018, 12:04 a.m., Sailaja Polavarapu wrote: > > With this change unixauthnative will not build by default in linux > > environment right?
Yes, in linux environment. There no problem in windows, and I am not tested with mac. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69136/#review210062 ----------------------------------------------------------- On 十月 24, 2018, 9:26 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69136/ > ----------------------------------------------------------- > > (Updated 十月 24, 2018, 9:26 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, > Selvamohan Neethiraj, sam rome, Venkat Ranganathan, Velmurugan Periasamy, > and Zsombor Gegesy. > > > Bugs: RANGER-2265 > https://issues.apache.org/jira/browse/RANGER-2265 > > > Repository: ranger > > > Description > ------- > > To make the profile "all" to be active by default when ranger build > > After merge https://issues.apache.org/jira/browse/RANGER-2243 patch, we need > to pass -Pall to the build. > Refer command: > mvn -DskipTests=true clean compile package install assembly:assembly -Pall > > If use the following command would cause failue: > mvn -DskipTests=true clean compile package install assembly:assembly > > OS name: "linux", version: "2.6.32-431.el6.x86_64", arch: "amd64", family: > "unix" > [INFO] Reactor Summary: > [INFO] > [INFO] ranger ............................................. SKIPPED > [INFO] Unix Native Authenticator .......................... SKIPPED > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [ERROR] Could not find goal 'assembly' in plugin > org.apache.maven.plugins:maven-assembly-plugin:3.0.0 among available goals > help, single -> [Help 1] > > Use the following command to find default profile, > we can see the profile "linux" is active: > > mvn help:active-profiles -N > Active Profiles for Project 'org.apache.ranger:ranger:pom:2.0.0-SNAPSHOT': > The following profiles are active: > - env-settings (source: external) > - env-unix (source: external) > - linux (source: org.apache.ranger:ranger:2.0.0-SNAPSHOT) > Which we expect the default profile "all" to be active. > > Refer to the Maven issue: > Profile not active even though it has activeByDefault set to true > https://issues.apache.org/jira/browse/MNG-4917 > > And from Introduction to Build Profiles: > This profile will automatically be active for all builds unless another > profile in the same pom is activated using one of the previously described > methods. All profiles that are active by default are automatically > deactivated when a profile in the pom is activated on the command line or > through its activation config. > In short, the profile "linux" disables "all" when ranger build without > specifying the profile id. > > To make the profile "all" to be active by default, > we should remove the property "activation" of profile "linux". > In fact, the property "activation" of profile "linux" make no sense, > just prompt us to compile under linux os, > and it should not be activated automatically instead of "all". > It should be activated by specifying the profile id: > mvn -DskipTests=true clean compile package install assembly:assembly -Plinux > > > Diffs > ----- > > pom.xml 1df10ed > > > Diff: https://reviews.apache.org/r/69136/diff/1/ > > > Testing > ------- > > Tested? > mvn -DskipTests=true clean compile package install assembly:assembly > Work fine without -Pall > > > Thanks, > > Qiang Zhang > >
