----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69156/#review210170 -----------------------------------------------------------
security-admin/src/main/webapp/templates/helpers/XAHelpers.js Lines 529 (patched) <https://reviews.apache.org/r/69156/#comment294796> It's better if we use icon for showing disable status instead of label. - Nitin Galave On Oct. 25, 2018, 9:22 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69156/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 9:22 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, sam rome, Venkat Ranganathan, and Velmurugan > Periasamy. > > > Bugs: RANGER-2267 > https://issues.apache.org/jira/browse/RANGER-2267 > > > Repository: ranger > > > Description > ------- > > On the Service Manager page, the enabled service and the disabled service are > displayed the same, and the user cannot distinguish between them. > Add a "disabled" lable to differentiate the status of the service > > Modified screenshots: > > https://issues.apache.org/jira/secure/attachment/12945573/Modify.PNG > > > Diffs > ----- > > security-admin/src/main/webapp/templates/helpers/XAHelpers.js 27de701ae > > > Diff: https://reviews.apache.org/r/69156/diff/1/ > > > Testing > ------- > > Test Result: > > Tested. > > > Thanks, > > Qiang Zhang > >
