----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69466/#review211137 -----------------------------------------------------------
Ship it! Ship It! - pengjianhua On 十一月 28, 2018, 8:16 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69466/ > ----------------------------------------------------------- > > (Updated 十一月 28, 2018, 8:16 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, > Selvamohan Neethiraj, sam rome, Venkat Ranganathan, Velmurugan Periasamy, > and Zsombor Gegesy. > > > Bugs: RANGER-2294 > https://issues.apache.org/jira/browse/RANGER-2294 > > > Repository: ranger > > > Description > ------- > > When edit user email address, and input the incorrect email address, > there are two kinds of error message: > 1.Input [email protected], there is error message: > Invalid email address > [JsValidateEmail.jpg|https://issues.apache.org/jira/secure/attachment/12949801/JsValidateEmail.jpg] > > 2.Input [email protected], there is error message: > Please provide valid email address. > [JavaValidateEmail.jpg|https://issues.apache.org/jira/secure/attachment/12949800/JavaValidateEmail.jpg] > > It is not reasonable when email address passed front-end validation, > but failed back-end validation. > So front-end and back-end email address regular expression should be the same, > and add hint message for user to fill email address. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 2c0ee98 > security-admin/src/main/webapp/scripts/views/users/UserForm.js ee0d256 > > > Diff: https://reviews.apache.org/r/69466/diff/1/ > > > Testing > ------- > > #Test Result: > Test OK. > [FixedJsValidateEmail.jpg|https://issues.apache.org/jira/secure/attachment/12949805/FixedJsValidateEmail.jpg] > > > Thanks, > > Qiang Zhang > >
