----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69524/#review211261 -----------------------------------------------------------
Ship it! Ship It! - Sailaja Polavarapu On Dec. 7, 2018, 10 a.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69524/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2018, 10 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2307 > https://issues.apache.org/jira/browse/RANGER-2307 > > > Repository: ranger > > > Description > ------- > > Currently credValidator and pamCredValidator don't handle well configuration > problems - when the user doesn't have permission to read /etc/shadow or > access pam, or when the shadow file is not filled properly. This could cause > 'core dumps', and hard to fix deployment issues. > > With this change, at least, it doesn't segfaults, when the crypt function > returns null, and it shows the underlying error message in its response. > > > Diffs > ----- > > unixauthnative/src/main/c/credValidator.c e426bdd2f > unixauthpam/src/main/c/pamCredValidator.c 60d38aebd > > > Diff: https://reviews.apache.org/r/69524/diff/1/ > > > Testing > ------- > > Tryied to call both method on live cluster - as root / non-root, with wrong > username, missing password from shadow file, etc. > > > Thanks, > > Zsombor Gegesy > >
