----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68620/#review211615 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Line 26 (original), 26 (patched) <https://reviews.apache.org/r/68620/#comment296970> Patch does not apply. Could you please update? ``` $ git apply --check -v < ~/Downloads/0001-RANGER-2206-Add-Policy-Validity-Period-and-Override-.patch.old Checking patch agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java... Checking patch security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java... error: while searching for: import java.util.Date; import java.util.HashMap; import java.util.HashSet; import java.util.LinkedHashMap; import java.util.LinkedHashSet; import java.util.List; error: patch failed: security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java:26 error: security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java: patch does not apply Checking patch security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java... Checking patch security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java... Hunk #2 succeeded at 2580 (offset 77 lines). Hunk #3 succeeded at 2592 (offset 77 lines). Checking patch security-admin/src/main/webapp/scripts/modules/globalize/message/en.js... Checking patch security-admin/src/main/webapp/scripts/utils/XAEnums.js... Checking patch security-admin/src/main/webapp/scripts/utils/XAUtils.js... Hunk #1 succeeded at 842 (offset -1 lines). Hunk #2 succeeded at 1481 (offset 15 lines). Checking patch security-admin/src/main/webapp/scripts/views/common/CustomSubgrid.js... Checking patch security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js... Checking patch security-admin/src/main/webapp/styles/xa.css... ``` - Velmurugan Periasamy On Sept. 4, 2018, 2:35 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68620/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2018, 2:35 p.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan > Periasamy. > > > Bugs: RANGER-2206 > https://issues.apache.org/jira/browse/RANGER-2206 > > > Repository: ranger > > > Description > ------- > > – Add policy validity period as search filter in policy listing page. Both > start date and end date (along with timezone). Search should show policies > that have validity period specified and meet that condition. > – Add policy override as search filter in policy listing page. Search should > show only policies defined as override. > – Add indication in policy listing page to distinguish policies with validity > period and override policies. Add icons for visual clue. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > 9924cb4 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 32af4cd > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 7b0fd87 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 59741d3 > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 99cbf55 > security-admin/src/main/webapp/scripts/utils/XAEnums.js ea80545 > security-admin/src/main/webapp/scripts/utils/XAUtils.js d9366a1 > security-admin/src/main/webapp/scripts/views/common/CustomSubgrid.js > ad89a13 > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js > 1150838 > security-admin/src/main/webapp/styles/xa.css c601d54 > > > Diff: https://reviews.apache.org/r/68620/diff/1/ > > > Testing > ------- > > 1.User is able to perform search through Start Time, End Time,Timezone and > Override. > 2.Verified that there is indication available for Override policy > 3.Verified that policy table shows results as per the search criteria along > with those policies which does not have 4.validity schedule. > 5.Verified that there is icon available next to the Policy ID, upon clicking > on that it display details of all Validity periods with respect to that > policy. > 6.Verified search functionality through Curl command as well. > > > Thanks, > > Nitin Galave > >
