----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69677/ -----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Ramesh Mani, and Velmurugan Periasamy. Bugs: RANGER-2287 https://issues.apache.org/jira/browse/RANGER-2287 Repository: ranger Description ------- **Problem Statement:** There are lot of repeated code in db_setup.py which can be removed which shall help developers to make any changes in db_setup.py in future. **Proposed Solution:** Proposed patch shall remove the db setup methods of each db flavor and shall use a single method for a specific work for each db flavor. Based on the db flavor, config values shall be populated and handled in the code after this patch. Diffs ----- security-admin/scripts/db_setup.py f1223b38c Diff: https://reviews.apache.org/r/69677/diff/1/ Testing ------- **Use Cases covered for all the db flavors:** *1. Fresh installation(Ranger 2.0):* Tested patch with fresh installation of ranger admin. *2. Upgrade(from 0.7 to 2.0):* Installed Ranger from 0.7 branch and used same db config on Ranger 2.0 installation config and run the setup.sh. Ranger was upgraded successfully. Thanks, Pradeep Agrawal