----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69731/#review211937 -----------------------------------------------------------
security-admin/pom.xml Line 608 (original), 611 (patched) <https://reviews.apache.org/r/69731/#comment297501> ${basedir}/target is the same as ${project.build.directory}, isn't it? Can you use it everywhere? - Zsombor Gegesy On Jan. 12, 2019, 2:41 p.m., Csaba Koncz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69731/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2019, 2:41 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2321 > https://issues.apache.org/jira/browse/RANGER-2321 > > > Repository: ranger > > > Description > ------- > > - Docker image building installs the packages needed by installing and > running PhantomJS > - modified Maven build so that PhantomJS downloading and execution can be > skipped by adding -DskipJSTests to the command line > > > Diffs > ----- > > README.txt 8aa177927 > build_ranger_using_docker.sh fa77d910f > security-admin/pom.xml 14cafb4b2 > security-admin/src/main/webapp/package-lock.json 9deaf0071 > security-admin/src/main/webapp/package.json 880f6b34f > security-admin/src/test/javascript/karma-common.conf.js 4dc9bb60f > security-admin/src/test/javascript/package-lock.json PRE-CREATION > security-admin/src/test/javascript/package.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/69731/diff/1/ > > > Testing > ------- > > The following succeeds and runs JavaScript tests: > > ``` > ./build_ranger_using_docker.sh -build_image mvn clean verify -am -pl > security-admin > ``` > > The following succeeds and does not run JavaScript tests and does not > download PhantomJS: > ``` > mvn clean verify -am -pl security-admin -DskipJSTests > ``` > > > Thanks, > > Csaba Koncz > >
