----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69853/#review212414 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Jan. 29, 2019, 1:04 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69853/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2019, 1:04 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Nikhil P, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-2327 > https://issues.apache.org/jira/browse/RANGER-2327 > > > Repository: ranger > > > Description > ------- > > Update Security zone table schema should use common sequence name for Oracle > and Postgres. It seems during the code refactoring in the oracle schema > sequnce name was modified(possibly due to identifier length is restricted to > 30 characters in oracle) but not at the postgres schema. we need to mention > the sequence names in the entity classes to avoid sequence name mismatch > issue. > > > Diffs > ----- > > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > f90248a28 > security-admin/db/oracle/patches/037-create-security-zone-schema.sql > 357e73fb2 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 79357ed5d > security-admin/db/postgres/patches/037-create-security-zone-schema.sql > 6baa7b975 > security-admin/scripts/db_setup.py cab9e59a1 > > security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefGroup.java > 91d90703b > > security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefResource.java > 3d68ba317 > > security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefService.java > 56ec01862 > > security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefUser.java > 3e5736621 > > > Diff: https://reviews.apache.org/r/69853/diff/1/ > > > Testing > ------- > > tested the patch with oracle and postgres db flavor. > > > Thanks, > > Pradeep Agrawal > >