----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70006/#review212927 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Feb. 19, 2019, 12:59 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70006/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2019, 12:59 p.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-2335 > https://issues.apache.org/jira/browse/RANGER-2335 > > > Repository: ranger > > > Description > ------- > > Steps to reproduce: > 1) In HDFS service definition, for path resource field set exclude and > recursive support to true. > 2) Go to HDFS-Policy creation/edit page. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/XAOverrides.js c45f74d > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js > e494bcc > security-admin/src/main/webapp/styles/xa.css 7fb868d > security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html > 856e92a > > > Diff: https://reviews.apache.org/r/70006/diff/1/ > > > Testing > ------- > > 1. Verified that overlap of "include" toggle button does not occur in case of > exclude & recursive support sets to true. > 2. Covered following test scenario's for resource `path`: > exclude:true, recursive:false : > exclude:false, recursive:true: > exclude:true, recursive:true : > exclude:false, recursive:false: > 3. Tested by adding new resources as well. > > > Thanks, > > Nitin Galave > >
