----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70240/#review214007 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On March 25, 2019, 7:01 a.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70240/ > ----------------------------------------------------------- > > (Updated March 25, 2019, 7:01 a.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-2354 > https://issues.apache.org/jira/browse/RANGER-2354 > > > Repository: ranger > > > Description > ------- > > Add custom conditions at policy level. > Currently custom condition is at policy item level and having at policy level > also will give more flexible and intutive. Also policy evaluation doesn't > need to go the policy item level for checking conditions which are applicable > at policy level. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 03412d5 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 57e72ba > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js > PRE-CREATION > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 931babf > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js > e6634cc > security-admin/src/main/webapp/styles/xa.css a09e3be > security-admin/src/main/webapp/templates/helpers/XAHelpers.js 1d4f04e > > security-admin/src/main/webapp/templates/policies/PolicyConditionsItem_tmpl.html > PRE-CREATION > > security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html > 1d683ad > security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html > a50903c > > > Diff: https://reviews.apache.org/r/70240/diff/2/ > > > Testing > ------- > > 1.Able to add policy condition at policy level using policy form. > 2.Verfied CRUD operation for policy condition field. > > > Thanks, > > Nitin Galave > >
