-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70327/#review214139
-----------------------------------------------------------


Fix it, then Ship it!





ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java
Line 250 (original), 258 (patched)
<https://reviews.apache.org/r/70327/#comment300320>

    - consider replacing #258 with:
        classLoader = savedClassLoader.getParent();
      else, line #267 will print a warn
    - remove lines #259, #260 - as the warn message will be logged in line #267.


- Madhan Neethiraj


On March 27, 2019, 9:45 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70327/
> -----------------------------------------------------------
> 
> (Updated March 27, 2019, 9:45 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2376
>     https://issues.apache.org/jira/browse/RANGER-2376
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2376:Ranger Plugin ClassLoader Doesn't Restore Thread ClassLoader
> 
> 
> Diffs
> -----
> 
>   
> ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java
>  41f53c0 
> 
> 
> Diff: https://reviews.apache.org/r/70327/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in Local VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Reply via email to