----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70339/#review214521 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On March 29, 2019, 12:18 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70339/ > ----------------------------------------------------------- > > (Updated March 29, 2019, 12:18 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2386 > https://issues.apache.org/jira/browse/RANGER-2386 > > > Repository: ranger > > > Description > ------- > > The same code appears in lot's of places, because > RangerCredentialProvider.getCredentialString returns a char array, which > needs to be converted to String - remove this duplication. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/DbAuditProvider.java > 1490c2782a9d603b8ad1392a1aafef7655e56562 > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > eff38249e044a9111110b747aa7e81003028d2b3 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > 2a4b9c90186effdcc2d9bc5b8726a5351ea668bd > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java > 2036661e81201b15fc296d53f2a831a8a1770b36 > > agents-cred/src/main/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProvider.java > 44cadfba2dc2f209a94b11f6d3ad7e7582f3d8cb > > agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java > 971ee681a33dfcf5993e4d79e25c648c90646df2 > > > Diff: https://reviews.apache.org/r/70339/diff/1/ > > > Testing > ------- > > Tested with plugins on a cluster > > > Thanks, > > Zsombor Gegesy > >
