----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70447/#review214538 -----------------------------------------------------------
Seems to be conflicting with https://reviews.apache.org/r/70432/ Could you please take a look and fix this? ``` [ERROR] /Users/vperiasamy/git/tlp-ranger/master/ranger/security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java:[113,25] error: method getAllZones in class SecurityZoneREST cannot be applied to given types; ``` - Velmurugan Periasamy On April 10, 2019, 1:01 p.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70447/ > ----------------------------------------------------------- > > (Updated April 10, 2019, 1:01 p.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-2384 > https://issues.apache.org/jira/browse/RANGER-2384 > > > Repository: ranger > > > Description > ------- > > Get All Zones API is returning response in raw format,proper response object > is required. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java > 299e256 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 574166c > security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java > b8b8c1b > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java > 04003f4 > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/view/RangerSecurityZoneList.java > PRE-CREATION > > security-admin/src/main/webapp/scripts/collection_bases/RangerZoneListBase.js > 8180414 > security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > d2f8a91 > > security-admin/src/test/java/org/apache/ranger/biz/TestSecurityZoneDBStore.java > 3d7c3ef > > security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java > e4b5a1b > > > Diff: https://reviews.apache.org/r/70447/diff/1/ > > > Testing > ------- > > 1)Verified If proper response is coming in get All zones. > 2)Tested on local VM. > > > Thanks, > > Nikhil P > >
