-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70389/
-----------------------------------------------------------
(Updated April 11, 2019, 8:24 a.m.)
Review request for ranger.
Changes
-------
Unit test fix
Bugs: RANGER-2394
https://issues.apache.org/jira/browse/RANGER-2394
Repository: ranger
Description
-------
Currently the audit search only allows to:
* filter to one user's activity
* exclude all 'service users' from every user's activity.
If there were way to search for multiple users or exclude multiple users from
the search list, it would make debugging complex interactions simpler, for
example only look for actions for 'alice' and 'hive' and 'yarn'
The frontend tweaked a bit, so if multiple users are passed to the jquery
layer, the user names are always converted as
requestUser=aaa&requestUser=bbb&requestUser=ccc instead of changing to
requestUser[]=aaa&requestUser[]=bbb&requestUser[]=ccc, which would be an
incompatible change between the server and to any potential client code.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java
ce577e0fc73a02962f923b13317021cd1feef38b
security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java
fdf5ad86bff91e811c7d56ceb87845f158f8c789
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
cf2a3b4d8862d738f882b6157cd1e9a317613aa7
security-admin/src/main/webapp/scripts/utils/XAUtils.js
b14f4b918a23be4f8ae1ae95308c90ebb3e4bcf6
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
daf6924ebb8b3f6dc0935736275d3e8d1c1f3f0b
security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java
ef149d5fa01b72f1ec3631012db4cf3433570547
Diff: https://reviews.apache.org/r/70389/diff/2/
Changes: https://reviews.apache.org/r/70389/diff/1-2/
Testing
-------
Tested on a live cluster that:
* searching for one user
* searching for multiple users
* excluding one user
* excluding multiple users
* searching for one user + 'excluding service users'
* searching for multiple users + 'excluding service users'
* excluding one user + 'excluding service users'
* excluding multiple users + 'excluding service users'
works as expected.
Thanks,
Zsombor Gegesy
