----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70456/#review214591 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10027.java Lines 116 (patched) <https://reviews.apache.org/r/70456/#comment300766> If xXServiceDefObj is null (hive-service-definition does not exist in the database), should the patch flag error and fail (by throwing exception)? It is not supposed to happen, right? security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10027.java Lines 123 (patched) <https://reviews.apache.org/r/70456/#comment300767> Same as comment for line 116. Further, on line 139, NPE may be thrown if dbHiveServiceDef is null. security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10027.java Lines 128 (patched) <https://reviews.apache.org/r/70456/#comment300764> Are lines 128-130 necessary? The only expected change is for Access-Types. Resource-Definitions are not expected to change for this patch. We should preserve Resource-Definitions across this migration. security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10027.java Lines 131 (patched) <https://reviews.apache.org/r/70456/#comment300765> If embeddedHiveAccessTypes is expected to be null, method checkNewAccessTypesPresent() - line 170 - does not seem to consider that. Please review. security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10027.java Lines 146 (patched) <https://reviews.apache.org/r/70456/#comment300769> Same comment as before (lines 116, 123). - Abhay Kulkarni On April 11, 2019, 2:32 p.m., Austin Nobis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70456/ > ----------------------------------------------------------- > > (Updated April 11, 2019, 2:32 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2374 > https://issues.apache.org/jira/browse/RANGER-2374 > > > Repository: ranger > > > Description > ------- > > Created a patch file for the Hive Service Definition to add the Refresh > access type. This is to support sharing a service definition between Apache > Hive and Apache Impala. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10027.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70456/diff/1/ > > > Testing > ------- > > > Thanks, > > Austin Nobis > >
