----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70376/#review214664 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On April 15, 2019, 1:26 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70376/ > ----------------------------------------------------------- > > (Updated April 15, 2019, 1:26 p.m.) > > > Review request for ranger, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep > Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2392 > https://issues.apache.org/jira/browse/RANGER-2392 > > > Repository: ranger > > > Description > ------- > > Currently, Resource-based services are associated with the zone as part of > zone creation. > Need to add a feature to only associate Tag based service as part of zone. > No need to add resources with tag-based service association. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java > 547e2d2 > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 0a529b4 > security-admin/db/mysql/patches/037-create-security-zone-schema.sql aff9786 > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 9be7e8d > security-admin/db/oracle/patches/037-create-security-zone-schema.sql > aae31dc > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > ec39c32 > security-admin/db/postgres/patches/037-create-security-zone-schema.sql > 4a94d26 > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > abfe120 > security-admin/db/sqlanywhere/patches/037-create-security-zone-schema.sql > 5b7dade > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > 1e8dff9 > security-admin/db/sqlserver/patches/037-create-security-zone-schema.sql > e621b43 > > security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java > 2b0c462 > security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java > cdb5e11 > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java > 3599cf3 > > security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefTagService.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java > ec69d6e > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java > 7927e31 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c1 > security-admin/src/main/webapp/scripts/models/RangerZone.js 4f99c83 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 29c33f5 > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js > d3eb026 > security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js > 2a07020 > > security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js > 63fafb4 > security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js > dd34605 > security-admin/src/main/webapp/styles/xa.css 60e045c > > security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html > a2f1374 > > security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html > 89acb10 > > security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html > fdcb821 > > > Diff: https://reviews.apache.org/r/70376/diff/4/ > > > Testing > ------- > > 1. Verified that new field "Zone Tag Services" is available on Zone form > (create/update page). > 2. Verified that multiple Tag services can be mapped to zone using newly > added field i.e "Zone Tag Services". > 3. Verified that Same Tag services can be mapped to multiple zones. > 4. Zone detail page display tag services associated with that zone. > 5. Verified that When tag based services is not mapped to any zone, It > displays message "No tag based services are associated with this zone" on > Zone listing page. > 6. Verified that Audit>>Admin logs gets generated for zone tag services field > in zone form > 7.Verified with databse flavours: MYSQL, Oracle, postgres, Sql anywhere, > MSSQL. > > > Thanks, > > Nitin Galave > >
