----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70493/#review214804 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Line 2119 (original), 2130 (patched) <https://reviews.apache.org/r/70493/#comment301058> Is type of service exported along with service name? It is required during import to minimize (by auto-selecting only services in the destination cluster of the same type) user inputs. security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Line 2052 (original), 2057 (patched) <https://reviews.apache.org/r/70493/#comment301057> Many methods are getting too long and it is difficult to follow logic. Please consider breaking them down along functional lines for maintainability. security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 2123 (patched) <https://reviews.apache.org/r/70493/#comment301054> Please review what this line is doing. security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 2147 (patched) <https://reviews.apache.org/r/70493/#comment301055> Even if sourceZoneName is empty, it will get added to sourceZones if destinationZoneName is not empty. (same holds for destinationZoneName). Please review to check if this is what you want. security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 2207 (patched) <https://reviews.apache.org/r/70493/#comment301056> Please use consistent formatting for spaces around operators, here and elsewhere. - Abhay Kulkarni On April 22, 2019, 10:59 a.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70493/ > ----------------------------------------------------------- > > (Updated April 22, 2019, 10:59 a.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-2351 > https://issues.apache.org/jira/browse/RANGER-2351 > > > Repository: ranger > > > Description > ------- > > Implement Import / Export of Policies by Zone. > Similar to, how we have Import Export by Service,Import/export by zone > feature is required. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 17be098 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 6cb85f9 > > security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefServiceDao.java > d568d81 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 6ddb359 > > security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java > acba730 > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > 771feec > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 97cc58b > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 19bb04b > security-admin/src/main/webapp/scripts/utils/XAGlobals.js 8036d2f > security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js > 2b5cfdd > security-admin/src/main/webapp/scripts/views/UploadServicePolicy.js 68022e9 > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js > fd3bb4e > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7589bfa > > security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js > 3df0ec4 > > security-admin/src/main/webapp/templates/common/uploadservicepolicy_tmpl.html > 150a885 > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 8f39607 > > > Diff: https://reviews.apache.org/r/70493/diff/3/ > > > Testing > ------- > > 1.tested If policies export after selecting a zone on "Access based policy" > page, exports only policies in that zone. > 2.Validated If no zone is selected on "Access based policy" page, exports > only policies which are not present in any zone. > 3.validated If policy import works properly and policies gets imported to > destination zone , provided correct mapping is given and zones are already > mapped to the services at destination. > > > File Attachments > ---------------- > > RANGER-2351-Implement-Import-Export-of-Policies-by-Z.patch > > https://reviews.apache.org/media/uploaded/files/2019/04/18/beb14579-4600-4950-af31-2a758b5dfca5__RANGER-2351-Implement-Import-Export-of-Policies-by-Z.patch > > > Thanks, > > Nikhil P > >
