-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/#review215029
-----------------------------------------------------------



Fix it and ship it


security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java
Lines 457 (patched)
<https://reviews.apache.org/r/70565/#comment301398>

    Do we need to check isAdmin() here again?


- Ramesh Mani


On May 3, 2019, 8:54 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70565/
> -----------------------------------------------------------
> 
> (Updated May 3, 2019, 8:54 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2411
>     https://issues.apache.org/jira/browse/RANGER-2411
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Restrict Admin role user to create Zone for KMS service
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> 4f6fa89 
>   
> security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
> edb3102 
> 
> 
> Diff: https://reviews.apache.org/r/70565/diff/2/
> 
> 
> Testing
> -------
> 
> Tested if Admin user is not able to create zone for KMS service.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Reply via email to