----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70614/#review215178 -----------------------------------------------------------
Ship it! Ship It! - bhavik patel On May 9, 2019, 8:06 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70614/ > ----------------------------------------------------------- > > (Updated May 9, 2019, 8:06 a.m.) > > > Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh > Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2419 > https://issues.apache.org/jira/browse/RANGER-2419 > > > Repository: ranger > > > Description > ------- > > **Problem Description:** If previous version of ranger(<=0.6) is installed > without atlas service def then upgrading ranger to higher version may fail > because statement > https://github.com/apache/ranger/blob/master/security-admin/db/oracle/patches/035-update-schema-for-x-policy.sql#L208 > will will return no results and oracle pl/sql engine doesn't handle it > internally. > > **Proposed solution:** First check if any record exist then only load the > results in internal variable. > > > Diffs > ----- > > security-admin/db/oracle/patches/035-update-schema-for-x-policy.sql > 3afdf47d8 > > > Diff: https://reviews.apache.org/r/70614/diff/1/ > > > Testing > ------- > > **Steps performed to test the patch on Ranger-admin** > > To reproduce the case first installed ranger-0.6 for oracle db flavor. In > install.properties file provided below values for the properties > policymgr_supportedcomponents => hdfs,hive,hbase,knox,storm > > Now from the master branch. > Created Build with patch and untar the build. > Opened install.properties and provided db configuration in install.properties > which was provided in ranger-0.6 branch build. > Called setup.sh > Ranger setup process shall try to apply the new db patches. > > **Expected Behaviour:** > Ranger installation should proceed without db patch 035 failure > **Actual Behaviour:** > Ranger installation finished successfully without db patch 035 failure. > > > Thanks, > > Pradeep Agrawal > >
