----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70642/#review215258 -----------------------------------------------------------
Ship it! Ship It! - Selvamohan Neethiraj On May 14, 2019, 1:34 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70642/ > ----------------------------------------------------------- > > (Updated May 14, 2019, 1:34 p.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2427 > https://issues.apache.org/jira/browse/RANGER-2427 > > > Repository: ranger > > > Description > ------- > > Policies downloaded to plugin have empty string as a value for zone-name. > This causes the check for zone-name of policy(empty string) and zone-name of > accessed resource(null) to fail. Consequently, none of the tag policies will > match. > > zone-name check condition is fixed to account for empty zone-name in policy. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 365edcf35 > > > Diff: https://reviews.apache.org/r/70642/diff/1/ > > > Testing > ------- > > Tested with a cluster with no configured security zone and with a tag policy. > Ensured that tag policy is selected for evaluation when the accessed resource > matches tagged resource. > > > Thanks, > > Abhay Kulkarni > >
