-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70675/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay
Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani,
Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2434
https://issues.apache.org/jira/browse/RANGER-2434
Repository: ranger
Description
-------
**Problem Statement:** After moving to guava-25, class
com.google.common.base.Objects is not available in the library and the
toStringHelper() method of the same class has been moved to
com.google.common.base.MoreObjects.
If debug mode is enabled then ranger-kms start tries to call
com.google.common.base.Objects.toStringHelper() to print the debug logs but
start fails as the class is no more available in guava jar.
**Proposed solution:** There are two way to fix the problem:
Option-1: Add the guava library dependency and change the
com.google.common.base.Objects to com.google.common.base.MoreObjects.
Option-2: concate the attribute and valies using string concatenation.
The proposed patch is having option-2 implementation.
**Note:**
There are other 3 classes(given below) which are using
com.google.common.base.MoreObjects but changing the implementation using
option-2 shall not help removing the dependency as the same classes are using
other classes of the guava library.
https://github.com/apache/ranger/blob/master/hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java
https://github.com/apache/ranger/blob/master/hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
https://github.com/apache/ranger/blob/master/hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationFilter.java
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java
5fc3358c6
Diff: https://reviews.apache.org/r/70675/diff/1/
Testing
-------
Tested the ranger build and ranger-kms installation
Thanks,
Pradeep Agrawal
