----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70711/#review215509 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On May 24, 2019, 2:17 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70711/ > ----------------------------------------------------------- > > (Updated May 24, 2019, 2:17 p.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-2446 > https://issues.apache.org/jira/browse/RANGER-2446 > > > Repository: ranger > > > Description > ------- > > If a policy which is part of security zone is edited, it will be good to > include the zonename also along with policyid and policyname in the popup > where admin audit details are displayed > > - This RR also covers RANGER-2444 changes as well. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > 0276367 > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js > 767f278 > > security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js > cc9ee8d > security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js > e0fab23 > > security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html > 04aa6dc > > security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html > dbc519a > > security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html > e150c32 > > > Diff: https://reviews.apache.org/r/70711/diff/2/ > > > Testing > ------- > > Verified that " Zone name" get displayed on audit>>admin tab: > 1. When performed CRUD operation on Zoned-resource based policies. > 2. When performed CRUD operation on Zoned-Tag based policies. > > Verified that " Policy condition" get displayed on audit>>admin tab: > 1. When performed CRUD operation on policies. > > > Thanks, > > Nitin Galave > >
