-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70763/#review215631
-----------------------------------------------------------


Fix it, then Ship it!





security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10028.java
Lines 297 (patched)
<https://reviews.apache.org/r/70763/#comment302402>

    RangerResourceDef has few more attributes - like: 
type/level/parent/mandatory/lookupSupported/excludesSupported/matcher/matcherOptions.
 Please review if these can be copied as well.


- Madhan Neethiraj


On June 2, 2019, 10:01 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70763/
> -----------------------------------------------------------
> 
> (Updated June 2, 2019, 10:01 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Nitin Galave, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-2453
>     https://issues.apache.org/jira/browse/RANGER-2453
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Tag policy for data masking may be created with multiple values for tag 
> resource using Ranger UI. UI should allow only one value for tag resource, as 
> for tag access policy.
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
>  b0dd283f0 
>   
> security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10028.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70763/diff/2/
> 
> 
> Testing
> -------
> 
> Ensured that when creating/updating a tag-based masking policy using UI, only 
> one tag value is allowed as policy-resource.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Reply via email to