----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70781/#review215683 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java Line 88 (original), 88 (patched) <https://reviews.apache.org/r/70781/#comment302476> For backward compatibility, I would suggest to check earlier configuration name if no value is specified for the new configuration name - like: if (StringUtils.isEmptyy(clusterName)) { clusterName = RangerConfiguration.getInstance().get(propertyPrefix + ".ambari.cluster.name", ""); } Same for renaming of "ambari.cluster.name" as well. - Madhan Neethiraj On June 4, 2019, 11:31 a.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70781/ > ----------------------------------------------------------- > > (Updated June 4, 2019, 11:31 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, > Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2458 > https://issues.apache.org/jira/browse/RANGER-2458 > > > Repository: ranger > > > Description > ------- > > – The property name should be renamed to something like: > ranger.plugin.hive.access.cluster.name. i.e. replace ‘ambari’ with ‘access’. > > – Also "ambari.service.check.user" config used during service creation needs > to remove "ambari" from it. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 81bbdbd > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > cff768f > > knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java > b04de1d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 2933392 > > > Diff: https://reviews.apache.org/r/70781/diff/1/ > > > Testing > ------- > > Verified cluster name value specified in concern property on audit section. > > > Thanks, > > bhavik patel > >
