----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70938/#review216214 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java Lines 60 (patched) <https://reviews.apache.org/r/70938/#comment303316> It seems that the clusterType is not used anywhere on ranger-admin side (for example, it is not added to the download audit record). In that case, why is this parameter added to download request here and in other REST client classes? agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAccessedNotFromClusterTypeCondition.java Lines 54 (patched) <https://reviews.apache.org/r/70938/#comment303315> getClusterName() ==> getClusterType() agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java Lines 66 (patched) <https://reviews.apache.org/r/70938/#comment303318> Please remove if providing clusterType in download request is not necessary. knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java Lines 71 (patched) <https://reviews.apache.org/r/70938/#comment303317> Please review an earlier comment. - Abhay Kulkarni On June 24, 2019, 3:07 p.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70938/ > ----------------------------------------------------------- > > (Updated June 24, 2019, 3:07 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2467 > https://issues.apache.org/jira/browse/RANGER-2467 > > > Repository: ranger > > > Description > ------- > > Need to add clusterType custom condition,This will help with custom > conditions like “Accessed from cluster type?” > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 23871f3 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAccessedFromClusterTypeCondition.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAccessedNotFromClusterTypeCondition.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequest.java > cb06d26 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java > 1f2f8ea > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestReadOnly.java > d5563bd > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPluginContext.java > 36dcec1 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 0edf149 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java > 67c068b > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java > 40bf1bd > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java > 33b26e0 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java > f373339 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > cce5129 > > hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java > 6dd81fa > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java > ce5cf64 > > knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java > ba44b96 > > > Diff: https://reviews.apache.org/r/70938/diff/1/ > > > Testing > ------- > > Tested for hive plugin, whether clusterType is being set properly in > RangerAccessRequest. > > > Thanks, > > Mateen Mansoori > >
