> On June 29, 2019, 12:05 a.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java > > Lines 201 (patched) > > <https://reviews.apache.org/r/70973/diff/1/?file=2152867#file2152867line201> > > > > Please ensure that the pathToCheck starts with string in 'ret'. If it > > does then return substring following 'ret' string. In that case getPath() > > function is not needed.
we need to have this getPatch method, so the subsequently when we do split and build the elements for resurvice matching we will have "scheme://" added to that list. This I verified and work as expected. - Ramesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70973/#review216237 ----------------------------------------------------------- On June 30, 2019, 10:09 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70973/ > ----------------------------------------------------------- > > (Updated June 30, 2019, 10:09 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, > and Velmurugan Periasamy. > > > Bugs: RANGER-2480 > https://issues.apache.org/jira/browse/RANGER-2480 > > > Repository: ranger > > > Description > ------- > > RANGER-2480:Hive URL Policy doesn't match if recursive flag is on for the url > resource > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java > PRE-CREATION > agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json > 370ff56 > > agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcherTest.java > PRE-CREATION > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 7aa9b3f > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 100ee9e > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > eac6a75 > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > b836ff1 > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > cca959a > > security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10030.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70973/diff/2/ > > > Testing > ------- > > - Verified in LOCAL VM for Patch file upgrade > - Verified URL policies for HIVE Request. > > > Thanks, > > Ramesh Mani > >
