> On July 8, 2019, 11 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > > Line 105 (original), 105 (patched) > > <https://reviews.apache.org/r/71037/diff/1/?file=2154024#file2154024line105> > > > > Please note that a change to Presto service-definition requires that if > > presto service is installed already, then it needs to be updated externally > > (using cURL or Java client), before the changes can be effective. This does > > not apply for new installation or Presto plugin. > > Bolke de Bruin wrote: > this isnt in any release yet so is this "upgrade path" required then? > where can i find where upgrades are executed?
Since this is not in a release, it might be ok. For reference, service defs are updated during upgrade with a java patch. See https://github.com/apache/ranger/blob/master/security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10030.java - Velmurugan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71037/#review216431 ----------------------------------------------------------- On July 8, 2019, 8:12 p.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71037/ > ----------------------------------------------------------- > > (Updated July 8, 2019, 8:12 p.m.) > > > Review request for ranger and Abhay Kulkarni. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-2502 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2502 > > > Repository: ranger > > > Description > ------- > > Fix service definition for Presto (update was used instead of insert) > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > f0ecf6b43 > > > Diff: https://reviews.apache.org/r/71037/diff/1/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Bolke de Bruin > >
