----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70838/#review216570 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On July 12, 2019, 6:16 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70838/ > ----------------------------------------------------------- > > (Updated July 12, 2019, 6:16 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Nitin Galave, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-2425 > https://issues.apache.org/jira/browse/RANGER-2425 > > > Repository: ranger > > > Description > ------- > > Implemented role management support in hive plugin and added some > validations. I included the changes done by Abhay & Nitin for roles with in > roles in this patch. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/AbstractRangerAdminClient.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java > 683d53b1d > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 23871f36f > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerRole.java > 88567e0b6 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 60b41352e > > agents-common/src/main/java/org/apache/ranger/plugin/store/RolePredicateUtil.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/util/GrantRevokeRequest.java > 11ff5b15a > > agents-common/src/main/java/org/apache/ranger/plugin/util/GrantRevokeRoleRequest.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java > 40bf1bda1 > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 4b9848de1 > > hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/RangerAdminClientImpl.java > 434bf40f4 > > hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerAdminClientImpl.java > 51ede3e83 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > de74cc7c3 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizerBase.java > a21d4620c > > hive-agent/src/test/java/org/apache/ranger/services/hive/RangerAdminClientImpl.java > e1c30d097 > > knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java > ba44b969c > > knox-agent/src/test/java/org/apache/ranger/services/knox/RangerAdminClientImpl.java > a15905e75 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/RangerAdminClientImpl.java > 9ed94ff2a > > plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerAdminClientImpl.java > 619672726 > > plugin-kylin/src/test/java/org/apache/ranger/authorization/kylin/authorizer/RangerAdminClientImpl.java > 926a21126 > > plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerAdminClientImpl.java > 689650b57 > security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java > 3de2548c4 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > bf50df3a8 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 947b23003 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java > baf6b6ea4 > security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java 5b6028f0b > security-admin/src/main/java/org/apache/ranger/db/XXRoleRefRoleDao.java > 80e0854df > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > 17239c96f > security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 8a5c812dc > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 171d73bfa > security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java > 2fb2ce637 > > security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java > cbdb5ce27 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml eb0384b14 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 22cdc83b7 > security-admin/src/main/webapp/scripts/views/users/AddUsersOrGroupsList.js > a93e58f7e > security-admin/src/main/webapp/scripts/views/users/RoleCreate.js f57480220 > security-admin/src/main/webapp/scripts/views/users/RoleForm.js 27c8aa95f > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > a18833e00 > security-admin/src/main/webapp/templates/users/RoleForm_tmpl.html 05b4acd12 > > storm-agent/src/test/java/org/apache/ranger/authorization/storm/RangerAdminClientImpl.java > 5a7c7dbb7 > > > Diff: https://reviews.apache.org/r/70838/diff/13/ > > > Testing > ------- > > 1. Tested on a secure cluster for different role operation from hive like > create role, delete role, show role, grant role, revoke role, and show roles. > > > Thanks, > > Sailaja Polavarapu > >
