----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71116/#review216762 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On July 18, 2019, 1:59 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71116/ > ----------------------------------------------------------- > > (Updated July 18, 2019, 1:59 p.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-2509 > https://issues.apache.org/jira/browse/RANGER-2509 > > > Repository: ranger > > > Description > ------- > > Step to reproduce : > > 1. Goto Service Manager Page, Click on "import" button. > 2. Select Import file format other than JSON. > > Expected result : > 1. Show validation message 'Please select json file'. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/UploadServicePolicy.js 7371c2b > > security-admin/src/main/webapp/templates/common/uploadservicepolicy_tmpl.html > 1e4621a > > > Diff: https://reviews.apache.org/r/71116/diff/1/ > > > Testing > ------- > > Tested with different file formats. > > > Thanks, > > Nitin Galave > >