----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71001/#review216787 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On July 17, 2019, 5:12 a.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71001/ > ----------------------------------------------------------- > > (Updated July 17, 2019, 5:12 a.m.) > > > Review request for ranger, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-1644 > https://issues.apache.org/jira/browse/RANGER-1644 > > > Repository: ranger > > > Description > ------- > > Allow individuals to use stronger encryption algorithms supported by JDK 1.8. > Applied mainly original patch from Endre > Kovacs(https://reviews.apache.org/r/63209/). > Just created the new patch by fixing the test case which was failing on > latest master branch. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 6480b17 > > agents-common/src/test/java/org/apache/ranger/plugin/util/PasswordUtilsTest.java > 4e135aa > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > bf50df3 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java > 2ddb5f3 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 8ebeeb5 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > dc845cf > > > Diff: https://reviews.apache.org/r/71001/diff/1/ > > > Testing > ------- > > Service Created And Updated : Service users password which was > created(encrypted) with old algo i.e PBEWithMD5AndDES was updated > successfully with new set of java 1.8 encryption algo's i.e > https://docs.oracle.com/javase/8/docs/technotes/guides/security/SunProviders.html#SunJCEProvider > . > > -Service CRUD on fresh installation. > -Tested with different algorithm on jdk1.8 > -Old Service CRUD after upgrade from 2.6 with jdk1.7 to 3.1maint with jdk1.8 > > PasswordUtilsTest: added new unit test and updated previous ones. > Added service update test: on service update new service password will be > encrypted with the new algorithm. > > > Thanks, > > Mateen Mansoori > >
