----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71126/#review216938 -----------------------------------------------------------
plugin-ozone/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java Lines 70 (patched) <https://reviews.apache.org/r/71126/#comment304177> Can ozoneObject be null, if so we may need to check for it? plugin-ozone/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java Lines 91 (patched) <https://reviews.apache.org/r/71126/#comment304176> typo plugin-ozone/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java Lines 106 (patched) <https://reviews.apache.org/r/71126/#comment304178> if accessType == null do we need to build the request as it going to return false. Please consider modifying this part if possible. plugin-ozone/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java Lines 174 (patched) <https://reviews.apache.org/r/71126/#comment304180> Can this a switch statement with single return? String ret = null switch (Operation) { case: ACLType.READ ret = ACCESS_TYPE_READ ... } return ret; - Ramesh Mani On July 25, 2019, 11:06 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71126/ > ----------------------------------------------------------- > > (Updated July 25, 2019, 11:06 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Nitin Galave, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-2325 > https://issues.apache.org/jira/browse/RANGER-2325 > > > Repository: ranger > > > Description > ------- > > Initial implementation of Ranger plugin for Ozone. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > d82fd70ac > agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json > PRE-CREATION > plugin-ozone/conf/ozone-ranger-env.sh PRE-CREATION > plugin-ozone/conf/ranger-ozone-audit-changes.cfg PRE-CREATION > plugin-ozone/conf/ranger-ozone-audit.xml PRE-CREATION > plugin-ozone/conf/ranger-ozone-security-changes.cfg PRE-CREATION > plugin-ozone/conf/ranger-ozone-security.xml PRE-CREATION > plugin-ozone/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-ozone/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-ozone/pom.xml PRE-CREATION > plugin-ozone/scripts/install.properties PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java > PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/services/ozone/RangerServiceOzone.java > PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/services/ozone/client/OzoneClient.java > PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/services/ozone/client/OzoneConnectionMgr.java > PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/services/ozone/client/OzoneResourceMgr.java > PRE-CREATION > pom.xml 7cf134ce5 > ranger-ozone-plugin-shim/pom.xml PRE-CREATION > > ranger-ozone-plugin-shim/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java > PRE-CREATION > src/main/assembly/admin-web.xml 39fb05414 > src/main/assembly/plugin-ozone.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71126/diff/2/ > > > Testing > ------- > > 1. Tested basic Ozone CLI commands like create/show volumne/bucket/key on a > test cluster. > 2. Also tested basic commands using s3 api on test cluster > 3. Verified audits in Ranger admin UI > > > Thanks, > > Sailaja Polavarapu > >
