-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71226/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, 
Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-2520
    https://issues.apache.org/jira/browse/RANGER-2520


Repository: ranger


Description
-------

Prevent Roles to be saved in Ranger Role Management page when user or groups 
are not added to the role.


Diffs
-----

  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
8078829 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 5fca82c 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 f8b71e1 
  
security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js
 ce3af44 
  security-admin/src/main/webapp/scripts/views/users/AddUsersOrGroupsList.js 
8d23b80 
  security-admin/src/main/webapp/scripts/views/users/RoleCreate.js e7e9f06 
  security-admin/src/main/webapp/scripts/views/users/RoleForm.js a3fd9f3 
  security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 13f7681 
  
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html
 fc5c302 
  
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html
 0dcae38 
  
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html
 c06c237 


Diff: https://reviews.apache.org/r/71226/diff/1/


Testing
-------

1. Verified that Roles should not be saved without clicking on Add 
Users/Groups/Roles after selecting User/Group/Roles, There is proper error 
message: Please add selected user/group/roles to there respective table else 
user/group/roles will not be added.
2. Verified that multiple Users/Groups/Roles can be added in Role.


Thanks,

Nitin Galave

Reply via email to