----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71245/#review217124 -----------------------------------------------------------
Fix it, then Ship it! Fix and Ship it! ugsync/src/main/java/org/apache/ranger/unixusersync/model/XGroupInfo.java Lines 22 (patched) <https://reviews.apache.org/r/71245/#comment304391> Please remove unused import. Generates PMD violation. ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java Lines 24 (patched) <https://reviews.apache.org/r/71245/#comment304390> Please remove this unused import. Creates PMD violation. - Velmurugan Periasamy On Aug. 7, 2019, 10:55 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71245/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2019, 10:55 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2530 > https://issues.apache.org/jira/browse/RANGER-2530 > > > Repository: ranger > > > Description > ------- > > Fixed some memory leak issues as well as modified code to re-use jersey > client instance instead of creating new one for every request. > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > d451d7acd > ugsync/src/main/java/org/apache/ranger/unixusersync/model/XGroupInfo.java > b9e71916f > ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java > 5b814378f > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > 24956e013 > > > Diff: https://reviews.apache.org/r/71245/diff/1/ > > > Testing > ------- > > 1. Verified all the exisitng unit tests are run successfully > 2. Patched a test cluster and ran some long running tests and some functional > tests successfully. > 3. Collected few heap dumps during long running tests and verified memory > usage. > > > Thanks, > > Sailaja Polavarapu > >
